[Frontend] Add OpenAI Vision API Support #5237
Merged
+653
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 tasks
|
@DarkLight1337 This PR is probably good for first pass - I will mark it as "Ready for review" after I address your first round of review, along with adding more test and documentation. |
This was referenced Jun 4, 2024
|
With docs and tests modified - going to make this PR ready for review cc @DarkLight1337. |
|
Assuming that the tests pass, LGTM. I will double-check the docs after they have been built. |
|
Thanks for the review @simon-mo! I have addressed the comments and all related tests have passed. Could you take a look at the |
|
I have downloaded the CI log and confirm that this is the case (with the help of |
This was referenced Jun 7, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jun 10, 2024
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the final step of the release milestone of adding support for GPT4V compatible inference.
This PR fixes
and closes #4200